-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register repo when cloning and remove mount and unmount #203
Conversation
Register the repo when cloning rather than when mounting
e476e07
to
adf535d
Compare
adf535d
to
b14b20b
Compare
Scalar.FunctionalTests/Tests/EnlistmentPerTestCase/CaseOnlyFolderRenameTests.cs
Outdated
Show resolved
Hide resolved
b14b20b
to
681288f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the current build succeeds, I think we should merge as-is. The other TODOs can be their own PRs to keep the size small.
In particular, deleting the mount process code should be easy to demonstrate no change in behavior.
Thoughts?
Edit: italicized above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple things.
I can go aheads and do that. This will introduce a bit of a regression because right now repos are never being unregistered, however, my next PR can add the auto-unregister behavior we need to the service. |
- Remove mount and unmount verbs - Clone no longer calls mount - Removed mount-all and unmount-all from the service verb - Updated functional tests as needed for above changes - Remove code for unloading the kext from the installer, there is no kext for Scalar - Stop calling 'service --unmount-all' as '--unmount-all' is no longer supported. For now call '--help' instead (until the service is able to stop its inflight maintenance task).
681288f
to
e0c16fb
Compare
Resolves #15
Resolves #118
Part of the work required for #111
service
verb (removemount-all
andunmount-all
, renamelist-mounted
)Follow up work
clone
(and other verbs where appropriate) to write to the registry directly rather than communicating with the service over a pipe (part of the remaining work for [Mount Removal] Move repo registration from mount verb to clone verb #111)